-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update module github.com/xanzy/go-gitlab to v0.78.0 in go.mod #2960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests failed
WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649.
server/events/vcs/gitlab_client.go:224:5: SA1019: mr.MergeStatus is deprecated: This parameter is replaced by DetailedMergeStatus in GitLab 15.6. (staticcheck)
if mr.MergeStatus == "can_be_merged" &&
^
make: *** [Makefile:75: check-lint] Error 1
Exited with code exit status 2
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. ⚠ Warning: custom changes will be lost. |
From the 0.77.0 to 0.78.0 changes, it looks like this is the only necessary change for this upgrade - MergeStatus: "can_be_merged",
+ DetailedMergeStatus: "mergeable", The PR that deprecated atlantis/server/events/vcs/gitlab_client.go Line 224 in bfd88b0
But that causes the following test failures in atlantis/server/events/vcs/gitlab_client_test.go Lines 329 to 335 in bfd88b0
It's possible that the mocks have to be regenerated for the latest gitlab client.. I do not see any mocks in It's possible that one of these inputs needs to be updated for the new atlantis/server/events/vcs/gitlab_client_test.go Lines 351 to 353 in bfd88b0
|
This PR contains the following updates:
v0.77.0
->v0.78.0
Release Notes
xanzy/go-gitlab
v0.78.0
Compare Source
Configuration
📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.