Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix instrumented approve policies calling apply #2977

Merged
merged 1 commit into from
Jan 12, 2023
Merged

fix: Fix instrumented approve policies calling apply #2977

merged 1 commit into from
Jan 12, 2023

Conversation

Fabianoshz
Copy link
Contributor

@Fabianoshz Fabianoshz commented Jan 12, 2023 •
edited by nitrocode
Loading

what

  • Use ApprovePolicies instead of Apply for approved policies

why

  • Fixes approve policies calling apply runner.

references

@Fabianoshz Fabianoshz requested a review from a team as a code owner January 12, 2023 22:02
krrrr38
krrrr38 approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@krrrr38 krrrr38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jamengual jamengual merged commit 33bc28f into runatlantis:main Jan 12, 2023
@nitrocode nitrocode added this to the 0.22.3 milestone Jan 12, 2023
@jamengual
Copy link
Contributor

@Fabianoshz do you think is possible to add Test for this case ( I know I merged the PR sorry)

@Fabianoshz
Copy link
Contributor Author

@jamengual we certainly can, I'm just out of free time right now, I can add some tests on the weekend, should I open a new PR later on?

@jamengual
Copy link
Contributor

yes please, open a new PR for the tests, thanks Fabiano again.

@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krrrr38 krrrr38 krrrr38 approved these changes

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.3
Development

Successfully merging this pull request may close these issues.

v0.22.0+: approve_policies: results in error "Pull request must be mergeable before running apply."
4 participants
@Fabianoshz @jamengual @krrrr38 @nitrocode