-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): add no test dir tests, rename testdata dir #2986
Conversation
@@ -0,0 +1,79 @@ | |||
package templates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding more tests!
|
||
import "testing" | ||
|
||
func TestStrip(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this test!
Ah ok I see more commits so I moved this to a draft. Please let us know when this is ready to be reviewed. |
I just tried this no test fix, but it require more refactoring. so not do it in this PR. Now this PR is ready. Thanks. @nitrocode |
Thanks for adding more tests! We need so many!! |
what
mv events/matchers into events/mocks/matchersproject_command_builder_internal_test
raise cyclic import, so reverted.why
testdata
is common name for test speficic filesThe go tool will ignore a directory named "testdata", making it available to hold ancillary data needed by the tests.
tests
references