Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): add no test dir tests, rename testdata dir #2986

Merged
merged 8 commits into from
Jan 16, 2023

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented Jan 15, 2023

what

why

  • introduce more unit testings
  • In golang, testdata is common name for test speficic files

tests

  • github actions

references

@krrrr38 krrrr38 marked this pull request as ready for review January 15, 2023 23:42
@krrrr38 krrrr38 requested a review from a team as a code owner January 15, 2023 23:42
@@ -0,0 +1,79 @@
package templates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding more tests!


import "testing"

func TestStrip(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this test!

@nitrocode nitrocode added this to the v0.22.3 milestone Jan 16, 2023
@krrrr38 krrrr38 changed the title chore: add web_template/ansi strip/metrics tests, rename testdata dir chore: add no test dir tests, rename testdata dir Jan 16, 2023
@krrrr38 krrrr38 changed the title chore: add no test dir tests, rename testdata dir chore(test): add no test dir tests, rename testdata dir Jan 16, 2023
@nitrocode nitrocode marked this pull request as draft January 16, 2023 02:45
@nitrocode nitrocode self-requested a review January 16, 2023 02:46
@nitrocode
Copy link
Member

Ah ok I see more commits so I moved this to a draft. Please let us know when this is ready to be reviewed.

@nitrocode nitrocode removed this from the v0.22.3 milestone Jan 16, 2023
@krrrr38
Copy link
Contributor Author

krrrr38 commented Jan 16, 2023

? github.com/runatlantis/atlantis/server/events/matchers [no test files]

I just tried this no test fix, but it require more refactoring. so not do it in this PR.

Now this PR is ready. Thanks. @nitrocode

@krrrr38 krrrr38 marked this pull request as ready for review January 16, 2023 03:30
@nitrocode nitrocode added this to the v0.22.3 milestone Jan 16, 2023
@nitrocode nitrocode merged commit da48fb5 into runatlantis:main Jan 16, 2023
@nitrocode
Copy link
Member

Thanks for adding more tests! We need so many!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants