Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PR status summary should remove Note: Objects have changed outside of Terraform #3010

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented Jan 19, 2023

what

  • Add PlanSuccess.DiffSummary which returns only diff summary.
  • use it on the pr status updater

why

PlanSuccess.Summary returns outside diff message, too. In the PR plan status doesn't need that information.

tests

  • I have tested my changes by github action unit test

references

@krrrr38 krrrr38 requested a review from a team as a code owner January 19, 2023 01:51
@nitrocode nitrocode merged commit 9e3d887 into runatlantis:main Jan 19, 2023
@nitrocode
Copy link
Member

Thanks for the quick fix!

@nitrocode
Copy link
Member

I noticed one more issue (feat request?). We summarize on plan but not on apply so it just results in Apply complete status instead of Applied 2 created, 3 changed, 4 destroyed. I wrote up #3041 in case anyone is interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR status summary should remove Note: Objects have changed outside of Terraform
3 participants