Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove x/exp package #3085

Merged
merged 1 commit into from
Jan 31, 2023
Merged

chore: remove x/exp package #3085

merged 1 commit into from
Jan 31, 2023
+22 −13

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented Jan 31, 2023 •
edited by nitrocode
Loading

@krrrr38 krrrr38 requested a review from a team as a code owner January 31, 2023 07:52
@github-actions github-actions bot added dependencies PRs that update a dependency file go Pull requests that update Go code labels Jan 31, 2023
krrrr38
krrrr38 commented Jan 31, 2023
View reviewed changes
server/utils/slices.go
package utils

// SlicesContains reports whether v is present in s.
// https://pkg.go.dev/golang.org/x/exp/slices#Contains
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be available go1.21 or later.

golang/go#57433

nitrocode
nitrocode approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for all these nice fixes!

@nitrocode nitrocode added this to the v0.23.0 milestone Jan 31, 2023
@nitrocode nitrocode merged commit 930daef into runatlantis:main Jan 31, 2023
@krrrr38 krrrr38 changed the title chore: remove x package chore: remove x/exp package Feb 1, 2023
@nitrocode nitrocode mentioned this pull request Feb 8, 2023
Open
21 tasks
@nitrocode nitrocode mentioned this pull request Mar 31, 2023
Merged
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@krrrr38 @ijames-gc
chore: remove x package (runatlantis#3085)
472ed02
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@krrrr38 @ijames-gc
chore: remove x package (runatlantis#3085)
bd23ca8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

Assignees
No one assigned
Labels
dependencies PRs that update a dependency file go Pull requests that update Go code
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@krrrr38 @nitrocode