Poll Gitlab until changes are available #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jdsleppy
force-pushed
the
3210-poll-gitlab-until-changes-are-available
branch
from
58e2552
to
8baef8d
Compare
|
Ive tested this image, in our environment and its working. |
nitrocode
approved these changes
Mar 20, 2023
jamengual
approved these changes
Mar 20, 2023
|
@Jdsleppy thank you for the quick fix. Until v0.22.3 is released, please use the new image built from this merged PR. |
nitrocode
pushed a commit
that referenced
this pull request
May 5, 2023
Co-authored-by: Joel Sleppy <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
Co-authored-by: Joel Sleppy <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
Co-authored-by: Joel Sleppy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
To address #3210 , poll the Gitlab
/changesendpoint untilchanges_countis no longer an empty string.changes_countis one of several fields that changes type when Gitlab's eventual consistency resolves and merge request changes are returned in the response. It's the most relevant choice of field for #3210 which is concerned withClient.GetModifiedFiles().why
Recent backwards-incompatible changes in Gitlab's API break the workflow in Atlantis where the Gitlab client expects accurate values to be available immediately. Gitlab is documenting this change in behavior and not planning on reverting it, so Atlantis must adapt. Thankfully, experimentation shows that Gitlab returns accurate values after only a few seconds of waiting.
tests
docker buildx build --build-arg ATLANTIS_BASE_TAG_TYPE=debian -t atlantis:dev-debian-58e2552 .references