feat: add PULL_URL to environment variables #3302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
|
@shouichi thank you for the pr. Please fill out the pr template above and let us know if you can test this out end to end in your own setup to ensure you can link the pr to your audit system. |
|
@nitrocode Updated the PR body. Also confirmed that this change worked as expected. |
GenPage
approved these changes
Apr 16, 2023
GenPage
force-pushed
the
add-pull-url-to-env
branch
from
3681586
to
324a63f
Compare
Background: It is convenient to have the PR URL available so that we can link the PR that triggers the infrastructure changes from the audit logging system. For example, the google cloud provider adds user-supplied justification into google cloud audit logging via `CLOUDSDK_CORE_REQUEST_REASON` environment variable. https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/provider_reference#request_reason
GenPage
force-pushed
the
add-pull-url-to-env
branch
from
324a63f
to
0b5603f
Compare
nitrocode
pushed a commit
that referenced
this pull request
May 5, 2023
Background: It is convenient to have the PR URL available so that we can link the PR that triggers the infrastructure changes from the audit logging system. For example, the google cloud provider adds user-supplied justification into google cloud audit logging via `CLOUDSDK_CORE_REQUEST_REASON` environment variable. https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/provider_reference#request_reason
mtavaresmedeiros
pushed a commit
to mtavaresmedeiros/atlantis
that referenced
this pull request
Jul 3, 2023
Background: It is convenient to have the PR URL available so that we can link the PR that triggers the infrastructure changes from the audit logging system. For example, the google cloud provider adds user-supplied justification into google cloud audit logging via `CLOUDSDK_CORE_REQUEST_REASON` environment variable. https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/provider_reference#request_reason
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
Background: It is convenient to have the PR URL available so that we can link the PR that triggers the infrastructure changes from the audit logging system. For example, the google cloud provider adds user-supplied justification into google cloud audit logging via `CLOUDSDK_CORE_REQUEST_REASON` environment variable. https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/provider_reference#request_reason
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
Background: It is convenient to have the PR URL available so that we can link the PR that triggers the infrastructure changes from the audit logging system. For example, the google cloud provider adds user-supplied justification into google cloud audit logging via `CLOUDSDK_CORE_REQUEST_REASON` environment variable. https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/provider_reference#request_reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This change adds
PULL_URLto environment variables.why
It is convenient to have the PR URL available so that we can link the PR that triggers the infrastructure changes from the audit logging system. For example, the google cloud provider adds user-supplied justification into google cloud audit logging via
CLOUDSDK_CORE_REQUEST_REASONenvironment variable.tests
Built an image with this PR's change and confirmed that the audit logging system contains the
PULL_URL. The following workflow was used to exportCLOUDSDK_CORE_REQUEST_REASONenv var.references
https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/provider_reference#request_reason