feat: case insensitive pr comments #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xafardero
force-pushed
the
basic-case-insensitive-for-pr-comments
branch
from
3f08cfa
to
8dd89af
Compare
nitrocode
reviewed
Apr 30, 2023
xafardero
force-pushed
the
basic-case-insensitive-for-pr-comments
branch
from
63f7108
to
fc8310c
Compare
xafardero
force-pushed
the
basic-case-insensitive-for-pr-comments
branch
from
fc8310c
to
eb04363
Compare
nitrocode
changed the title
nitrocode
approved these changes
May 4, 2023
mtavaresmedeiros
pushed a commit
to mtavaresmedeiros/atlantis
that referenced
this pull request
Jul 3, 2023
* Basic case insensitive for pr comments. * Add test for uppercase/lowercase case. * Merge test functions that check similar behaviors. --------- Co-authored-by: nitrocode <[email protected]> Co-authored-by: PePe Amengual <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Basic case insensitive for pr comments. * Add test for uppercase/lowercase case. * Merge test functions that check similar behaviors. --------- Co-authored-by: nitrocode <[email protected]> Co-authored-by: PePe Amengual <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Basic case insensitive for pr comments. * Add test for uppercase/lowercase case. * Merge test functions that check similar behaviors. --------- Co-authored-by: nitrocode <[email protected]> Co-authored-by: PePe Amengual <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Lowercase the first 2 args of the comments in a PR when parsing it, so that
Atlantis Planwill be valid for example.why
Some users have issues writing commands to Atlantis via PR (mainly autocorrect), this PR tries to solve it and make the Atlantis use via PR more smoothly.
tests
make testreferences
Atlantis Plan#3337