fix(workflow-hook): multiline output formatting

[X-Guardian]

what

• In the pre and post workflow hook runners, the OutputHandler.SendWorkflowHook out parameter has the line feeds (\n) replaced with carriage return then line feed (\r\n).

why

• So that the pre and post workflow hook multiline output is formatted correctly.

tests

repos.yaml

repos:
- id: /.*/
  pre_workflow_hooks:
    - run: |
        echo "pre workflow test line 1a" && echo "pre workflow test line 1b"
        echo "pre workflow test line 2a" && echo "pre workflow test line 2b"
  post_workflow_hooks:
    - run: |
        echo "post workflow test line 1a" && echo "post workflow test line 1b"
        echo "post workflow test line 2a" && echo "post workflow test line 2b"

Output Screenshots

Pre Workflow Hook

Post Workflow Hook

Logs

Logs

{"level":"info","ts":"2023-05-21T16:27:55.106+0100","caller":"runtime/pre_workflow_hook_runner.go:77","msg":"successfully ran \"echo \\\"pre workflow test line 1a\\\" && echo \\\"pre workflow test line 1b\\\"\\necho \\\"pre workflow test line 2a\\\" && echo \\\"pre workflow test line 2b\\\"\\n\" in \"/root/.atlantis/repos/X-Guardian/atlantis-test/1/default\"","json":{"repo":"X-Guardian/atlantis-test","pull":"1"}}
{"level":"info","ts":"2023-05-21T16:27:56.381+0100","caller":"events/project_command_builder.go:399","msg":"found no atlantis.yaml file","json":{"repo":"X-Guardian/atlantis-test","pull":"1"}}
{"level":"info","ts":"2023-05-21T16:27:56.382+0100","caller":"events/project_command_builder.go:403","msg":"automatically determined that there were 0 projects modified in this pull request: []","json":{"repo":"X-Guardian/atlantis-test","pull":"1"}}
{"level":"info","ts":"2023-05-21T16:27:57.851+0100","caller":"runtime/post_workflow_hook_runner.go:77","msg":"successfully ran \"echo \\\"post workflow test line 1a\\\" && echo \\\"post workflow test line 1b\\\"\\necho \\\"post workflow test line 2a\\\" && echo \\\"post workflow test line 2b\\\"\\n\" in \"/root/.atlantis/repos/X-Guardian/atlantis-test/1/default\"","json":{"repo":"X-Guardian/atlantis-test","pull":"1"}}

references

• Fixes Multiline Output in pre and post Workflow Hook Scripts is not Correctly Formatted #3424

[nitrocode]

Thank you for adding tests. Please see the last comment regarding changing sh to bash

[nitrocode]

Please resolve conflicts @X-Guardian