-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: safer re-merging with updated upstream #3499
Commits on Jun 7, 2023
-
Safer handling of merging with an updated upstream.
We used to call forceClone() to update with upstream, but this deletes the checked out directory. This is inefficient, can delete existing plan files, and is very surprising if you are working manually in the working directory. We now fetch an updated upstream, and re-do the merge operation. This leaves any working files intact.
Configuration menu - View commit details
-
Copy full SHA for d9807ca - Browse repository at this point
Copy the full SHA d9807caView commit details
Commits on Jun 8, 2023
-
Rename SafeToReClone -> CheckForUpstreamChanges
It's never safe to clone again. But sometimes we need to check for upstream changes to avoid reverting changes. The flag is now used to know when we need to merge again non-destructively with new changes.
Configuration menu - View commit details
-
Copy full SHA for e093ca7 - Browse repository at this point
Copy the full SHA e093ca7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00ad2bb - Browse repository at this point
Copy the full SHA 00ad2bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5e9a4c - Browse repository at this point
Copy the full SHA f5e9a4cView commit details -
Add test to make sure plans are not wiped out
As long as the branch itself has not been updated, plans should be kept. Even if upstream has changed.
Configuration menu - View commit details
-
Copy full SHA for c0e6b20 - Browse repository at this point
Copy the full SHA c0e6b20View commit details -
renamed HasDiverged to MergedAgain in PlanResult and from Clone()
This flag was only set to true in case a call to Clone() ended up merging with an updated upstream, so the new name better represents what it means.
Configuration menu - View commit details
-
Copy full SHA for 88eac0a - Browse repository at this point
Copy the full SHA 88eac0aView commit details -
Test that Clone on branch update wipes old plans
This complements the test that Clone with unmodified branch but modified upstream does _not_ wipe plans.
Configuration menu - View commit details
-
Copy full SHA for ef5d2e2 - Browse repository at this point
Copy the full SHA ef5d2e2View commit details
Commits on Jun 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c94cda5 - Browse repository at this point
Copy the full SHA c94cda5View commit details
Commits on Aug 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 218de2a - Browse repository at this point
Copy the full SHA 218de2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74040a7 - Browse repository at this point
Copy the full SHA 74040a7View commit details -
Updated template to merged again instead of diverged
This is no longer a warning, but expected behavior in merge chekout mode
Configuration menu - View commit details
-
Copy full SHA for cf33681 - Browse repository at this point
Copy the full SHA cf33681View commit details
Commits on Aug 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9634103 - Browse repository at this point
Copy the full SHA 9634103View commit details
Commits on Aug 14, 2023
-
Rename git wrapper to wrappedGit, add a type for static config
Every call to wrappedGit for the same PR uses identical setup for directory, head repo and PR, so passing the
Configuration menu - View commit details
-
Copy full SHA for 2c0260d - Browse repository at this point
Copy the full SHA 2c0260dView commit details
Commits on Sep 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cf6684c - Browse repository at this point
Copy the full SHA cf6684cView commit details
Commits on Sep 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for da1373f - Browse repository at this point
Copy the full SHA da1373fView commit details