Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the 'Plan Discarded' Message from the Enable/Disable Apply Commands #3511

Merged
merged 2 commits into from
Jun 11, 2023

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Jun 11, 2023

what

Remove the incorrect ?discard=true query string from the lock and unlock conditions in the applyLockModalSetup function.

why

tests

Tested locally

@X-Guardian X-Guardian requested a review from a team as a code owner June 11, 2023 11:46
@github-actions github-actions bot added the go Pull requests that update Go code label Jun 11, 2023
@nitrocode nitrocode added this to the v0.24.3 milestone Jun 11, 2023
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all these contributions!

@nitrocode
Copy link
Member

Please join our slack and #contributors channel if you haven't already. 🚀

@nitrocode nitrocode merged commit 7fa9b9c into runatlantis:main Jun 11, 2023
mtavaresmedeiros pushed a commit to mtavaresmedeiros/atlantis that referenced this pull request Jul 3, 2023
…y Commands (runatlantis#3511)

* Remove `/?discard=true`

* Restore forward slash
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
…y Commands (runatlantis#3511)

* Remove `/?discard=true`

* Restore forward slash
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
…y Commands (runatlantis#3511)

* Remove `/?discard=true`

* Restore forward slash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect 'Plan Discarded' Message When Enabling/Disabling Apply Commands
2 participants