Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Dockerfile): re-add terraform 1.4 #3521

Merged
merged 1 commit into from
Jun 19, 2023
Merged

chore(Dockerfile): re-add terraform 1.4 #3521

merged 1 commit into from
Jun 19, 2023

Conversation

nitrocode
Copy link
Member

what

  • re-add terraform 1.4
  • maintain 4 releases as we previously had

why

  • Add 1.4 again since renovate updated to 1.5 and removed 1.4 by accident. Difficult to prevent this.
  • We previously had 4 releases so this maintains 4 releases cached in the container since each release is 80 MB making it expensive in bandwidth.

tests

  • I have tested my changes by creating the image

references

@nitrocode nitrocode added this to the v0.24.3 milestone Jun 14, 2023
@nitrocode nitrocode requested a review from a team as a code owner June 14, 2023 02:51
@github-actions github-actions bot added the build Relating to how we build Atlantis label Jun 14, 2023
@nitrocode
Copy link
Member Author

cc @runatlantis/maintainers please review

@nitrocode nitrocode merged commit 104cf8b into main Jun 19, 2023
@nitrocode nitrocode deleted the add-1.4-back-to-Dockerfile branch June 19, 2023 21:28
mtavaresmedeiros pushed a commit to mtavaresmedeiros/atlantis that referenced this pull request Jul 3, 2023
@nitrocode
chore(Dockerfile): re-add terraform 1.4 (runatlantis#3521)
de6d736
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@nitrocode @ijames-gc
chore(Dockerfile): re-add terraform 1.4 (runatlantis#3521)
b779bf8
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@nitrocode @ijames-gc
chore(Dockerfile): re-add terraform 1.4 (runatlantis#3521)
6eb84a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
build Relating to how we build Atlantis
Projects
None yet
Milestone
v0.24.3
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @jamengual