fix: debian version pinning #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
reviewed
Jun 14, 2023
Dockerfile
Outdated
| libcap2=1:2.44-1 \ | ||
| dumb-init=1.2.5-1 \ | ||
| gnupg=2.2.27-2+deb11u2 \ | ||
| openssl=1.1.1n-0+deb11u4 && \ |
There was a problem hiding this comment.
We do not want to pin here (even if that's the current result). The intention of using >= qualifier was to get the latest version since ~> qualifier isn't supported by apt.
If we change this then let's find a way to achieve the original intention.
There was a problem hiding this comment.
Sounds good, updated.
jamengual
reviewed
Jun 15, 2023
Dockerfile
Outdated
Comment on lines
38
to
41
| # hadolint ignore explanation | ||
| # DL3008 (pin versions using "=") - Ignored to avoid failing the build | ||
| # SC2261 (multiple redirections) - This is a bug https://github.com/hadolint/hadolint/issues/782 | ||
| # hadolint ignore=DL3008,SC2261 |
There was a problem hiding this comment.
you need this comments back otherwise hadolint will complain
There was a problem hiding this comment.
oops! I thought the comment meant the opposite, that you shouldn't pin the versions 🤦
Reverted!
mightyguava
force-pushed
the
yunchi/debian-install-fix
branch
from
29f51c1
to
3cbb477
Compare
GenPage
approved these changes
Jun 20, 2023
mtavaresmedeiros
pushed a commit
to mtavaresmedeiros/atlantis
that referenced
this pull request
Jul 3, 2023
* fix debian version pinning * unpin packages --------- Co-authored-by: PePe Amengual <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* fix debian version pinning * unpin packages --------- Co-authored-by: PePe Amengual <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* fix debian version pinning * unpin packages --------- Co-authored-by: PePe Amengual <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Unpin debian packages as was intended. Also removing
bashas it's already installed on the debian image.why
apt-getdoesn't support>=or any other kind of version constraints. It only supports version pinning via=. Thehadolinterror about multiple redirections was correct.The actual behavior of the existing code was that stuff like
curl>=7.74was being interpreted ascurl > "=7.74". Files like=7.74and=1:2.30were being created at/and all of the logs from the install went into the last redirect at=1.1.1n. None of the versions were being pinned.tests
Checked that the installed versions didn't change using
apt list.references