Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multienv): allow commas and quoted values #3542

Merged
merged 6 commits into from
Oct 6, 2023
Merged

fix(multienv): allow commas and quoted values #3542

merged 6 commits into from
Oct 6, 2023

Commits on Sep 8, 2023

  1. Make code more Go-idiomatic 

    While at it makes it more readable.

Signed-off-by: Leandro López (inkel) <[email protected]>
    @inkel
    inkel committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    eeff28c View commit details
    Browse the repository at this point in the history

  2. Add internal function to parse multienv step input 

    This new function properly deals with quotes and commas in values.

Signed-off-by: Leandro López (inkel) <[email protected]>
    @inkel
    inkel committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    df749c4 View commit details
    Browse the repository at this point in the history

  3. Add regression test for multienv output with comma in values 

    See runatlantis#2765 for an issue report.

Signed-off-by: Leandro López (inkel) <[email protected]>
    @inkel
    inkel committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    5b2e0cd View commit details
    Browse the repository at this point in the history

  4. Use parseMultienvLine for parsing multienv steps output 

    Signed-off-by: Leandro López (inkel) <[email protected]>
    @inkel
    inkel committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    069ca87 View commit details
    Browse the repository at this point in the history

  5. Add internal function to parse multienv step input 

    This new function properly deals with quotes and commas in values.

Signed-off-by: Leandro López (inkel) <[email protected]>
    @inkel
    inkel committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    c6c31ca View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Merge branch 'main' into inkel/multienv/proper-parsing-value-commas-q… 

    …uotes
    @jamengual
    jamengual committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    e425c9c View commit details
    Browse the repository at this point in the history