Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Gitlab Autoplan wont trigger when switching Draft to Ready #3568

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

X-Guardian
Copy link
Contributor

what

Updates the ParseGitlabMergeRequestUpdateEvent function to check if the MR title in the webhook event has changed from having a prefix of Draft: to not having a prefix of Draft:, which is how GitLab identifies that an MR is in a draft state.

why

tests

Locally

@X-Guardian X-Guardian requested a review from a team as a code owner July 2, 2023 17:26
@github-actions github-actions bot added the go Pull requests that update Go code label Jul 2, 2023
@X-Guardian X-Guardian changed the title Fix: Gitlab Autoplan wont trigger when switching Draft to Ready fix: Gitlab Autoplan wont trigger when switching Draft to Ready Jul 2, 2023
@X-Guardian
Copy link
Contributor Author

Maintainers, this PR is ready for review.

Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @X-Guardian for the contribution

@jamengual jamengual merged commit 0d1f878 into runatlantis:main Jul 5, 2023
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
…tlantis#3568)

* Fix: Gitlab Autoplan wont trigger when switching Draft to Ready

* Update gitlab-merge-request-event-mark-as-ready.json

---------

Co-authored-by: PePe Amengual <[email protected]>
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
…tlantis#3568)

* Fix: Gitlab Autoplan wont trigger when switching Draft to Ready

* Update gitlab-merge-request-event-mark-as-ready.json

---------

Co-authored-by: PePe Amengual <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitlab Autoplan wont trigger when switching Draft to Ready
2 participants