feat: Slack notifications matched on base branch name #3644
+67
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GenPage
requested changes
Aug 3, 2023
Thank you for reviewing! I added an additional test where both are set with invalid regex. |
krrrr38
reviewed
Aug 4, 2023
| if err != nil { | ||
| return nil, err | ||
| } | ||
| br, err := regexp.Compile(c.BranchRegex) |
There was a problem hiding this comment.
Does this become a breaking change? It might be better to use .* when passing empty string.
There was a problem hiding this comment.
No, I tested a webhooks config without defining either workspace-regex or branch-regex and the Slack notification still went through. For example, regexp.MatchString("", "main") evaluates to true, so looks like this will still function fine if the user does not set the branch-regex in the config.
There was a problem hiding this comment.
I see, thanks for your confirmation 👍
GenPage
approved these changes
Aug 5, 2023
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Add ability to send slack notification matched on base branch name * Update BranchRegex usage doc * Add test with invalid branch and workspace regex
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Add ability to send slack notification matched on base branch name * Update BranchRegex usage doc * Add test with invalid branch and workspace regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add ability to send Slack notifications matched on base branch name
why
We currently use the
defaultworkspace for a given Atlantis project but with separate branches per environment (production,staging, etc). We cannot filter the Slack notifications since they all match on thedefaultworkspace.tests
make testandmake test-allconfig.yaml:Produced the following slack notification:
