Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Bitbucket Server comments if over max length #372

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Dec 4, 2018

  • Refactor the comment split method into a common package

Fixes #280

- Refactor the comment split method into a common package
@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #372 into master will decrease coverage by 0.21%.
The diff coverage is 59.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
- Coverage   70.51%   70.29%   -0.22%     
==========================================
  Files          61       62       +1     
  Lines        3720     3733      +13     
==========================================
+ Hits         2623     2624       +1     
- Misses        909      921      +12     
  Partials      188      188
Impacted Files Coverage Δ
server/events/vcs/github_client.go 62.85% <0%> (-10.96%) ⬇️
server/events/vcs/bitbucketserver/client.go 35.82% <0%> (-2.28%) ⬇️
server/events/vcs/common/comment_splitter.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 387186e...bf19968. Read the comment docs.

@lkysow lkysow merged commit 9adb7eb into master Dec 4, 2018
@lkysow lkysow deleted the bitbucket-comment-length branch December 4, 2018 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant