feat: full window sized terminal #3781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X-Guardian
requested changes
Sep 25, 2023
GenPage
added
waiting-on-response
marcosdiez
changed the title
marcosdiez
force-pushed
the
full_screen_terminal
branch
from
aa537df
to
cffbc0e
Compare
|
Hi! I implemented all the suggestions and answered all the questions. I believe we are now ready to merge this PR. |
This PR will need to be reviewed by a maintainer first. I suggest you update the 'what' and 'why' in the PR description to help them review this. |
marcosdiez
force-pushed
the
full_screen_terminal
branch
from
f8953ac
to
57aa88c
Compare
|
@X-Guardian done and done! |
jamengual
added
waiting-on-review
jamengual
approved these changes
Nov 15, 2023
|
/cherry-pick release-0.26 |
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
Co-authored-by: PePe Amengual <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
Co-authored-by: PePe Amengual <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
The atlantis terminal (which we can see our jobs/terraform running) is now a full window sized terminal !
Fancy watermark included!
why
So we can see more information in the same screen.
tests
It's UI, no tests :)
references
it looks quite well on top of terminal text:
The PR can be quickly tested using the following docker container: marcosdiez/atlantis:v0.25.0b