feat: Jobs now shown in a table in the main page

[marcosdiez]

what

I wanted to see all the jobs running in/executed by atlantis in a single page.

why

This will help me see all my plans at once. They are sorted by age, which also helps. Will also help me to fix #3767 in the future.

Since the data is obtained from memory, it will be cleared when atlantis is restarted and therefore it should not show any dead links.

It may be a nice workaround for #3783

screenshot

and when there are no jobs,

The PR can be quickly tested using the following docker container: marcosdiez/atlantis:v0.25.0b

[X-Guardian]

Hi @marcosdiez, this would be a great addition to Atlantis.

I've run some tests using your branch and there are a few issues:

1. When a PR is merged or closed, the jobs belonging to the PR are not removed from the list.
2. The order of the jobs displayed is not consistent. I would suggest sorting them by repository, project, workspace then date.
3. The repository name, project and workspace don't always populate in the table.

I would also suggest displaying the list of jobs on a separate tab, rather than below the list of lock files. This could be achieved easily using something like this example: https://www.w3schools.com/howto/howto_js_tabs.asp

You also need to update the tests for the Go files you are changing.

[marcosdiez]

Hi @X-Guardian !

Thanks for reviewing.

About the order not being consistent, I could easily fix that. The biggest fix I actually need to do is that the row lines are not showing. I'll try to work on that as well.

Now why would I stop showing the logs of a merged PR ? If we have the data, I want it to be seen. The primary reason I wrote this code was because I was being affected by #3767 . So more data is better than less data. Maybe I could add a new column showing the PR status (opened/closed/merged) or something like that. I don't recall if we have that data in memory.

Also, I can't reproduce "The repository name, project and workspace don't always populate in the table.". We've been using it in an environment with more than 50 people (on GitHub) and this is not happening.

I don't mind implementing the tabs either nor unit tests.

That being said, I want to fix everything in one sit, so we need to agree on 1) and I need to know how to reproduce 3)
(or we agree we can survive without them)

Thanks

Marcos

[X-Guardian]

Hi Marcos. I have been testing it on GitLab. Let me try it on GitHub and see if I get the same issue with the repo name/project workspace not showing.

Regarding keeping all the log references. Eventually you are going to have so many that the Atlantis server will surely run out of memory and fall over, so I don't think that is viable.

[X-Guardian]

OK, the entries with no repository name, project or workspace are the outputs from pre/post workflow hooks.

[marcosdiez]

@X-Guardian I don't keep logs in memory. I just list all the logs there currently are in memory. If you look at my code, the only modification that I did is that whenever a "log in memory" is created, I am also saving the timestamp so I can later use it to sort.

So I won't ever cause atlantis to run out of memory :)

[marcosdiez]

Could you please show me a screenshot with pre/post workflow hooks so I can see what it looks like?

[X-Guardian]

Here you go:

[marcosdiez]

Sorting implemented and we now show lines below each row.

I just have to implement the list of tabs and fix the unit tests

[marcosdiez]

@X-Guardian all the tests pass now. I was thinking, I personally prefer two tables one below the other one. If you really want, I can implement the tabs, though.

[jamengual]

as @X-Guardian said we need to review it too.
Thanks @X-Guardian for the feedback.
@GenPage is extremely busy with other PRs so is going to have to wait a bit.

[jamengual]

@marcosdiez can you fix the lint errors?

[marcosdiez]

@jamengual done!

[jamengual]

@marcosdiez can you please fix the conflicts? Thanks.

[marcosdiez]

@jamengual done!

[X-Guardian]

The pre and post workflow hooks outputs are still broken in this.

[nitrocode]

Nice job with this PR. I do like seeing the exposed jobs.

The pre and post workflow hooks outputs are still broken in this.

Yep, I can confirm that the pre and post workflow jobs still show up as empty rows as indicated by @X-Guardian. I created the link issue above 4132. If you get a chance @marcosdiez, please look into it.