Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add project depends on functionality #3821

Merged

Conversation

vincentgna
Copy link
Contributor

what

  • The main purpose of this PR is to add Dependencies functionality to Atlantis. The change introduces a new key depends_on to the project config in the atlantis.yaml file.

why

Using the depends_on functionality will allow Atlantis to handle cases requiring one project to be applied prior to the other. In other words, allow promotions between projects/environments (dev -> staging -> production)

tests

  • I have tested my changes by adding new unit tests, running Atlantis locally, and testing the depends_on functionality.

references

@vincentgna vincentgna requested a review from a team as a code owner October 6, 2023 10:44
@github-actions github-actions bot added docs Documentation go Pull requests that update Go code labels Oct 6, 2023
Copy link
Member

@GenPage GenPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@GenPage GenPage merged commit cf2b791 into runatlantis:main Oct 6, 2023
15 checks passed
@vincentgna
Copy link
Contributor Author

Thanks for quick merge, I just realised the depends_on docs are unreachable.

I'll do a separate PR to fix the docs

@jamengual
Copy link
Contributor

as commented on the issue , we will revert this since it introduces a bug @lukemassa @vincentgna

agreed ?

@vincentgna
Copy link
Contributor Author

as commented on the issue , we will revert this since it introduces a bug @lukemassa @vincentgna

agreed ?

fine by me, I set the docs fix PR into draft mode as well.

@vincentgna

This comment was marked as resolved.

jamengual added a commit that referenced this pull request Oct 6, 2023
@vincentgna vincentgna deleted the feat-add-project-depends-on-functionality branch October 6, 2023 15:34
GenPage pushed a commit that referenced this pull request Oct 6, 2023
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
* feat: implemented the code for the depends on functionnality

* chore: Address PR comments

---------

Co-authored-by: Luay-Sol <[email protected]>
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
* feat: implemented the code for the depends on functionnality

* chore: Address PR comments

---------

Co-authored-by: Luay-Sol <[email protected]>
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants