fix: When GitHub/GitLab Auto-Merge Is Used with Atlantis Pre Workflow Hooks, the PR will be Merged Prematurely #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GenPage
approved these changes
Nov 4, 2023
|
/cherry-pick release-0.26 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Nov 4, 2023
… Hooks, the PR will be Merged Prematurely (#3880) * Fix Premature Auto-Merge * Add CommitStatusUpdater to commandRunner
GenPage
pushed a commit
that referenced
this pull request
Nov 6, 2023
… Hooks, the PR will be Merged Prematurely (#3880) * Fix Premature Auto-Merge * Add CommitStatusUpdater to commandRunner
GenPage
pushed a commit
that referenced
this pull request
Nov 10, 2023
… Hooks, the PR will be Merged Prematurely (#3880) * Fix Premature Auto-Merge * Add CommitStatusUpdater to commandRunner
GenPage
pushed a commit
that referenced
this pull request
Nov 11, 2023
… Hooks, the PR will be Merged Prematurely (#3880) * Fix Premature Auto-Merge * Add CommitStatusUpdater to commandRunner
GenPage
pushed a commit
that referenced
this pull request
Nov 14, 2023
… Hooks, the PR will be Merged Prematurely (#3880) * Fix Premature Auto-Merge * Add CommitStatusUpdater to commandRunner
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
… Hooks, the PR will be Merged Prematurely (runatlantis#3880) * Fix Premature Auto-Merge * Add CommitStatusUpdater to commandRunner
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
… Hooks, the PR will be Merged Prematurely (runatlantis#3880) * Fix Premature Auto-Merge * Add CommitStatusUpdater to commandRunner
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
When a pre-workflow hook is launched for plan and apply commands, set the relevant plan/apply commit status to
pendingat the start of the hook. This prevents a VCS auto-merge feature from prematurely merging the PR when the pre-workflow hook finishes.Also, if
fail-on-pre-workflow-hook-erroris set, update the relevant plan/apply commit status to 'failed' at the end of the hook.Also fix the current 'unable to update pre workflow hook status' message text.
why
tests
Tested locally