feat: Remove flag for allow repo config #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
changed the title
lukemassa
force-pushed
the
remove_allow_repo_config
branch
from
08193eb
to
0d4e308
Compare
jamengual
added
refactoring
|
@lukemassa, could you fix this conflict? |
|
@jamengual fixed! |
GenPage
previously approved these changes
Dec 12, 2023
GenPage
previously approved these changes
Dec 12, 2023
|
@lukemassa test are failing with It looks like it happened after merging the main in (couldn't rebase). I'm checking the main branch commits |
|
Last commit looks fine: https://github.com/runatlantis/atlantis/actions/runs/7175678014/job/19539369727 |
|
Looking now |
auto-merge was automatically disabled
December 12, 2023 03:07
Head branch was pushed to by a user without write access
GenPage
approved these changes
Dec 12, 2023
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Remove option to allow repo * Fix internal test * Fix fmt * Fmt * Fix rebase --------- Co-authored-by: PePe Amengual <[email protected]> Co-authored-by: Dylan Page <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Remove option to allow repo * Fix internal test * Fix fmt * Fmt * Fix rebase --------- Co-authored-by: PePe Amengual <[email protected]> Co-authored-by: Dylan Page <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Remove flag
--allow-repo-configwhy
This has been deprecated since 1fcdaba.
That commit changed the semantics of
--allow-repo-config, which is important to clarify for the flag's removal. Before the deprecation,--allow-repo-configwas the only way to allow or disallow reading the atlantis.yaml in repos. Afterwards, however, the repo level atlantis.yaml is always read, and the new role of--allow-repo-configis to determine whether we should accept all values from the repo level yaml, or only particular ones, as specified in the new repo config.This is why the default of
--allow-repo-configis false. Removing this as an option means it will be impossible to specify that all values from the repo level yaml should be trusted, rather the repo config is necessary to allow overrides to important settings likeapply_requirements.I opted to keep AllowRepoConfig in
GlobalCfgArgs, renaming it toAllowAllRepoSettings, since it is convenient for testing. It however is not set inserver.goso isfalsein any production run.I also removed two deprecated functions from global_cfg.go, which between them were only called once, a call site that was easy to translate to the supported
NewGlobalCfgFromArgs.tests
Running unit tests to confirm existing behavior. Actual flag was removed:
references