Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove deprecated silence whitelist errors flag #3923

Merged

Conversation

lukemassa
Copy link
Contributor

what

Remove --silence-allowlist-errors flag.

why

This flag was deprecated in 8ac19e4

tests

This setting only appeared in configuration, and any behavior changes had been deferred to --silence-allowlist-errors, so unit tests passing should be sufficient.

The only functional change of this PR is then:

Error: unknown flag: --silence-whitelist-errors

references

Partially addresses #2992

@lukemassa lukemassa requested a review from a team as a code owner November 5, 2023 18:30
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 5, 2023
@jamengual
Copy link
Contributor

/cherry-pick release-0.26

@jamengual jamengual merged commit 9bc94de into runatlantis:main Nov 9, 2023
24 checks passed
@GenPage GenPage added feature New functionality/enhancement refactoring Code refactoring that doesn't add additional functionality breaking-change labels Dec 12, 2023
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change feature New functionality/enhancement go Pull requests that update Go code refactoring Code refactoring that doesn't add additional functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants