fix: removing mr.Headpipeline.Source log when mr.HeadPipeline is missing #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@X-Guardian FYI |
nitrocode
reviewed
Nov 22, 2023
| @@ -387,12 +387,12 @@ func (g *GitlabClient) UpdateStatus(repo models.Repo, pull models.PullRequest, s | |||
| break | |||
| } | |||
| if i != retries { | |||
| g.logger.Debug("Head pipeline not found for merge request %d, source '%s'. Retrying in %s", | |||
| pull.Num, mr.HeadPipeline.Source, delay) | |||
| g.logger.Debug("Head pipeline not found for merge request %d. Retrying in %s", | |||
There was a problem hiding this comment.
Is there another var that contains the source repo?
There was a problem hiding this comment.
https://docs.gitlab.com/ee/api/merge_requests.html#response
from the merge request API this is just the type of event that triggered the pipeline which doesn't seem important to log when there is no pipeline yet
chenrui333
approved these changes
Nov 22, 2023
|
LGTM |
|
thanks for your contribution @fitz7 |
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…ing (runatlantis#3996) * fix: removing mr.Headpipeline.Source log when mr.HeadPipeline is missing * fix: remove mr.HeadPipeline.Source from other log
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…ing (runatlantis#3996) * fix: removing mr.Headpipeline.Source log when mr.HeadPipeline is missing * fix: remove mr.HeadPipeline.Source from other log
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
when mr.HeadPipeline is missing and the gitlab client retries, it logs mr.HeadPipeline.Source which causes a panic:
why
Should fix the panic