Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI for markdown renderer #4066

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

lukemassa
Copy link
Contributor

what

Fixes CI in markdown_renderer_test.go

why

#4049 broke CI by changing the produced value for a number of rendered templates. I noticed this when running make test locally as well as in the failing tests for an unrelated PR https://github.com/runatlantis/atlantis/actions/runs/7234266257/job/19710468454?pr=4064.

I created this PR mechanically with the following command:

sed -i 's/delete all plans/**delete** all plans/g' server/events/markdown_renderer_test.go

tests

Before:

atlantis % go test github.com/runatlantis/atlantis/server/events      
% https://dev.azure.com/owner/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://owner.visualstudio.com/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://dev.azure.com/owner/project/_git/repo
% https://devops.abc.com/owner/project/_git/repo
% https://devops.abc.com/owner/project/_git/repo
% https://devops.abc.com/owner/project/_git/repo
% https://devops.abc.com/owner/project/_git/repo
% https://devops.abc.com/owner/project/_git/repo
% https://devops.abc.com/owner/project/_git/repo
% https://devops.abc.com/owner/project/_git/repo
% https://devops.abc.com/owner/project/_git/repo
% https://devops.abc.com/owner/project/_git/repo
% https://devops.abc.com/owner/project/_git/repo
% https://devops.abc.com/owner/project/_git/repo
% https://devops.abc.com/owner/project/_git/repo
% https://devops.abc.com/owner/project/_git/repo
% https://devops.abc.com/owner/project/_git/repo
% https://devops.abc.com/owner/project/_git/repo
--- FAIL: TestRenderProjectResults (0.01s)
    --- FAIL: TestRenderProjectResults/single_successful_plan (0.00s)
        --- FAIL: TestRenderProjectResults/single_successful_plan/single_successful_plan (0.00s)
            markdown_renderer_test.go:978: [Ran Plan for dir: `path` workspace: `workspace`
                
                ```diff
                terraform-output
                ```
                
                * :arrow_forward: To **apply** this plan, comment:
                    * `atlantis apply -d path -w workspace`
                * :put_litter_in_its_place: To **delete** this plan click [here](lock-url)
                * :repeat: To **plan** this project again, comment:
                    * `atlantis plan -d path -w workspace`
                
                ---
                * :fast_forward: To **apply** all unapplied plans from this pull request, comment:
                    * `atlantis apply`
                * :put_litter_in_its_place: To delete all plans and locks for the PR, comment:
                    * `atlantis unlock`
                
...

After:

atlantis % go test github.com/runatlantis/atlantis/server/events        
ok  	github.com/runatlantis/atlantis/server/events	28.315s

references

Caused by: #4049

@lukemassa lukemassa requested a review from a team as a code owner December 17, 2023 16:10
@github-actions github-actions bot added the go Pull requests that update Go code label Dec 17, 2023
@jamengual
Copy link
Contributor

thanks @lukemassa for figuring it out and the PR

@jamengual
Copy link
Contributor

/cherry-pick release-0.27

@jamengual jamengual merged commit 1e45e2f into runatlantis:main Dec 17, 2023
24 checks passed
@lukemassa lukemassa deleted the fix_ci_for_rendered_templates branch December 20, 2023 18:00
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants