chore: Move gitlab client test data into testdata/ files #4086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
requested review from
jamengual and
nitrocode
and removed request for
a team
|
Ah, looks like our CI prevents us from using |
lukemassa
force-pushed
the
move_gitlab_client_test_to_file
branch
from
25aa32c
to
e5c7a09
Compare
chenrui333
approved these changes
Dec 21, 2023
|
make sense, one nit comment, I wonder if it should be |
lukemassa
changed the title
lukemassa
added a commit
that referenced
this pull request
Jan 19, 2024
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…#4086) * feat: Move gitlab client test data into testdata/ files * Cleanup
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…#4086) * feat: Move gitlab client test data into testdata/ files * Cleanup
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Moving test data for testing gitlab client into dedicated testdata/ files
why
This is the way all the other VCSs handle responses. It makes it easier to read and tweak if need be. I believe there's a bug in the content of one of these strings, but I wanted to translate them to files so it's easier to track down and identify first.
tests
Ran unit tests
references