fix: download conftest binary for correct arch #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prajithp
requested review from
chenrui333,
lukemassa and
X-Guardian
and removed request for
a team
nitrocode
approved these changes
Dec 26, 2023
chenrui333
approved these changes
Dec 26, 2023
|
@Prajithp thanks for your first PR to Atlantis! |
|
/cherry-pick release-0.27 |
Signed-off-by: Prajith P <[email protected]>
Signed-off-by: Prajith P <[email protected]>
|
/cherry-pick release-0.27 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jan 21, 2024
* download conftest binary for correct arch Signed-off-by: Prajith P <[email protected]> * remove default constant Signed-off-by: Prajith P <[email protected]> --------- Signed-off-by: Prajith P <[email protected]>
GenPage
pushed a commit
that referenced
this pull request
Jan 21, 2024
* download conftest binary for correct arch * remove default constant --------- Signed-off-by: Prajith P <[email protected]> Co-authored-by: Prajith <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* download conftest binary for correct arch Signed-off-by: Prajith P <[email protected]> * remove default constant Signed-off-by: Prajith P <[email protected]> --------- Signed-off-by: Prajith P <[email protected]>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* download conftest binary for correct arch Signed-off-by: Prajith P <[email protected]> * remove default constant Signed-off-by: Prajith P <[email protected]> --------- Signed-off-by: Prajith P <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Download the conftest binary that corresponds to the correct architecture
why
The current conftest binary architecture is hardcoded, causing failures on ARM-based instances. This pull request will dynamically determine the architecture and download the correct binary.
tests
N/A