Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e-tests): add ngrok authtoken #4125

Merged
merged 1 commit into from
Jan 7, 2024
Merged

fix(e2e-tests): add ngrok authtoken #4125

merged 1 commit into from
Jan 7, 2024

Conversation

GenPage
Copy link
Member

@GenPage GenPage commented Jan 6, 2024

what

Fixes ngrok tunneling so that Github webhooks can hit the private instance of Atlantis in the CircleCI runners.

why

E2E tests are failing due to:

ERROR:  authentication failed: Usage of ngrok requires a verified account and authtoken.
ERROR:  
ERROR:  Sign up for an account: https://dashboard.ngrok.com/signup
ERROR:  Install your authtoken: https://dashboard.ngrok.com/get-started/your-authtoken
ERROR:  
ERROR:  ERR_NGROK_4018
ERROR:

references

https://ngrok.com/docs/errors/err_ngrok_4018/
https://app.circleci.com/pipelines/github/runatlantis/atlantis/6186/workflows/c2454924-90a4-4564-bcad-53eb29150f31/jobs/16363

@GenPage GenPage requested review from a team as code owners January 6, 2024 05:35
@GenPage GenPage requested review from jamengual, nitrocode and X-Guardian and removed request for a team January 6, 2024 05:35
@GenPage GenPage merged commit 34383f4 into main Jan 7, 2024
24 checks passed
@GenPage GenPage deleted the fix/e2e-tests-ngrok branch January 7, 2024 00:48
chenrui333
chenrui333 reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GenPage
Copy link
Member Author

GenPage commented Jan 8, 2024

/cherry-pick release-0.27

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 8, 2024
@GenPage
fix(e2e-tests): add ngrok authtoken (#4125)
8bfa17e
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jan 8, 2024
Merged
GenPage added a commit that referenced this pull request Jan 8, 2024
@gcp-cherry-pick-bot @GenPage
fix(e2e-tests): add ngrok authtoken (#4125) (#4129)
897d2e9 
Co-authored-by: Dylan Page <[email protected]>
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@GenPage @ijames-gc
fix(e2e-tests): add ngrok authtoken (runatlantis#4125)
bac1743
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@GenPage @ijames-gc
fix(e2e-tests): add ngrok authtoken (runatlantis#4125)
d7fc3a1
@BrewTestBot BrewTestBot mentioned this pull request May 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

@nitrocode nitrocode nitrocode approved these changes

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from runatlantis/maintainers

@X-Guardian X-Guardian Awaiting requested review from X-Guardian X-Guardian is a code owner automatically assigned from runatlantis/core-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GenPage @chenrui333 @nitrocode