Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unnamed jobs in ui, remove uppercasing #4137

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

tlorreyte
Copy link
Contributor

@tlorreyte tlorreyte commented Jan 10, 2024

what

  • Correct naming of pre and post workflow with their description fields
  • Uppercase removed from main page

why

As correctly described in #4132, the jobs were not clearly identifiable on the home page.
Several fields have been added to the output structure of the various jobs to enable them to be displayed.
On the PR, with a repos yaml like this :

  pre_workflow_hooks: 
    - run: echo toto
      description: echo toto
    - run: echo toto2
  
  post_workflow_hooks: 
    - run: echo tata
      description: echo tata

  workflow: custom

workflows:
  custom:
    plan:
      steps:
      - run: echo hi
      - init
      - plan
      - run: echo hello

the page looks like this :

Screenshot 2024-01-10 at 09 30 35

Unfortunately, the project and workspace fields will remain empty due to the differences between a job and hook context.

tests

The templating test has been enhanced with jobToMapping data.

references

@tlorreyte tlorreyte requested review from a team as code owners January 10, 2024 08:52
@tlorreyte tlorreyte requested review from jamengual, lukemassa and X-Guardian and removed request for a team January 10, 2024 08:52
@github-actions github-actions bot added the go Pull requests that update Go code label Jan 10, 2024
@tlorreyte
Copy link
Contributor Author

Any idea why netlify initialization fails ?

@lukemassa
Copy link
Contributor

3:55:46 AM: Attempting Node.js version "20.11.0" from .node-version
3:55:46 AM: Version "20.11.0" not found - try `nvm ls-remote` to browse available versions.
3:55:46 AM: Failed to install Node.js version "20.11.0"

It looks like this was updated by: #4136. I will update main then rebase this PR

@lukemassa
Copy link
Contributor

@tlorreyte I rebased the PR which fixed the issue.

Originally I had thought #4136 had caused the issue, but now I think it was just some transient failure

@nitrocode
Copy link
Member

Thank you for the fix.

Regarding the empty project and workspace, if the values are empty, can we remove the empty code formatting that's left there?

@GenPage GenPage added bug Something isn't working refactoring Code refactoring that doesn't add additional functionality waiting-on-response Waiting for a response from the user quick-win Is obviously something Atlantis should do and will take <4 hrs work regression Bug introduced in a new version ui labels Jan 20, 2024
@tlorreyte
Copy link
Contributor Author

@nitrocode sure, that should be possible

@tlorreyte
Copy link
Contributor Author

@nitrocode I've just added an if condition on empty strings, it should be enough :
image

Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitrocode
Copy link
Member

Nice job! Thank you all.

@nitrocode nitrocode merged commit 9fa4cd3 into runatlantis:main Feb 2, 2024
26 checks passed
@nitrocode nitrocode changed the title fix: unnamed jobs in ui fix: unnamed jobs in ui, remove uppercasing Feb 2, 2024
@GenPage
Copy link
Member

GenPage commented Mar 8, 2024

/cherry-pick release-0.27

GenPage pushed a commit that referenced this pull request Mar 8, 2024
@X-Guardian X-Guardian removed the waiting-on-response Waiting for a response from the user label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code quick-win Is obviously something Atlantis should do and will take <4 hrs work refactoring Code refactoring that doesn't add additional functionality regression Bug introduced in a new version ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.27: Unnamed jobs in UI
5 participants