Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve git error log while running 'atlantis apply' #4177

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix: improve git error log while running 'atlantis apply' #4177

merged 1 commit into from
Mar 5, 2024

Conversation

mmokijewski
Copy link
Contributor

@mmokijewski mmokijewski commented Jan 26, 2024

what

Improve error message printed by atlantis in case of errors coming from git ls-files . --others command when calling atlantis apply

why

For make debugging easier. My case was that I had defined Terragrunt cache directory (which is not git repository) just parallel to workspace directories. At first glance it was not obvious seeing such error what is going about, but after take a look in source code I found what exactly atlantis does under the hood. Improved error message could make cause finding much faster.
image

tests

Added unit test on previously uncovered code

references

It may also be helpful by debugging already existing issues like e.g. #2168 or #3139

@mmokijewski mmokijewski requested review from a team as code owners January 26, 2024 17:57
@mmokijewski mmokijewski requested review from GenPage, lukemassa and nitrocode and removed request for a team January 26, 2024 17:57
@github-actions github-actions bot added the go Pull requests that update Go code label Jan 26, 2024
@mmokijewski mmokijewski changed the title Improve git error log while running 'atlantis apply' fix: improve git error log while running 'atlantis apply' Jan 26, 2024
@GenPage GenPage added feature New functionality/enhancement waiting-on-response Waiting for a response from the user quick-win Is obviously something Atlantis should do and will take <4 hrs work needs tests Change requires tests labels Jan 26, 2024
lukemassa
lukemassa previously approved these changes Jan 27, 2024
server/events/pending_plan_finder.go Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Mar 5, 2024

This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month.

@github-actions github-actions bot added the Stale label Mar 5, 2024
@mmokijewski
Copy link
Contributor Author

This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month.

Dummy comment to add some activity

@GenPage GenPage merged commit d5b63d2 into runatlantis:main Mar 5, 2024
23 checks passed
@GenPage GenPage removed waiting-on-response Waiting for a response from the user Stale labels Mar 5, 2024
@GenPage
Copy link
Member

GenPage commented Mar 8, 2024

/cherry-pick release-0.27

@chenrui333 chenrui333 removed feature New functionality/enhancement needs tests Change requires tests labels May 22, 2024
@chenrui333 chenrui333 added the bug Something isn't working label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code quick-win Is obviously something Atlantis should do and will take <4 hrs work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants