chore: Add flag for SilenceVCSStatusNoProjects #4179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
requested review from
jamengual,
nitrocode and
X-Guardian
and removed request for
a team
github-actions
bot
added
docs
jamengual
approved these changes
Jan 28, 2024
lukemassa
force-pushed
the
add_flag_silence_vcs_status_no_project
branch
from
84d7669
to
8b6e241
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add a flag and documentation for
--silence-vcs-status-no-projects.why
The option was added to
server/user_config.gobut flag was never added tocmd/server.go.Note: there is some debate about whether this is a useful additional option given
--silence-vcs-status-no-plansand--silence-no-projects, which we may address at a later date. The goal of this PR is simply to unify the flags and yaml definitions for consistency.tests
Ran unit tests
references
Closes: #4068
Initially discussed in: #1469 (comment)