-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Contributor Guide on the Website #4514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing this, left couple of comments. 👍
772aff1
to
d00d246
Compare
Thanks for the comments @chenrui333. I pushed changes for them. Let me know if I can further improve the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
@elft3r thanks for your first contribution to atlantis! |
Thanks @chenrui333 for your support and getting this PR merged. Happy to help and hope that this is the first of many PRs from me 🤞 |
what
This is an initial version of a contributor guide on the website. It contains, for now, an explanation of how the
/events
Controller works and a basic Glossary page.why
As part of working on #4448, I need to dig deep into Atlantis's inner workings. As there was no documentation about this available, I came up with the idea of starting it.
It's the first version that is open for discussion. I'd like to know if this is the best place for something like this or if you think another place is more suitable.
I know the
CONTRIBUTING.md
file already exists, but I think we need another place for more in-depth information.Best,
Jochen