Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: refactor navbar and sidebar out of config #4523

Merged
merged 5 commits into from
May 8, 2024
Merged

docs: refactor navbar and sidebar out of config #4523

merged 5 commits into from
May 8, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented May 8, 2024 •
edited
Loading

@chenrui333 chenrui333 requested review from a team as code owners May 8, 2024 19:08
@chenrui333 chenrui333 requested review from GenPage, lukemassa and nitrocode and removed request for a team May 8, 2024 19:08
@chenrui333 chenrui333 marked this pull request as draft May 8, 2024 19:13
@chenrui333
Copy link
Member Author

there is some issue with the navbar again

image

@chenrui333 chenrui333 marked this pull request as ready for review May 8, 2024 19:26
@chenrui333
Copy link
Member Author

Should be good now.

@chenrui333
Copy link
Member Author

works fine now

image

@chenrui333 chenrui333 merged commit 1e7d7cf into main May 8, 2024
40 checks passed
@chenrui333 chenrui333 deleted the refactor-webpage branch May 8, 2024 20:13
@BrewTestBot BrewTestBot mentioned this pull request May 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@GenPage GenPage Awaiting requested review from GenPage GenPage is a code owner automatically assigned from runatlantis/maintainers

@lukemassa lukemassa Awaiting requested review from lukemassa lukemassa is a code owner automatically assigned from runatlantis/core-contributors

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from runatlantis/core-contributors

Assignees
No one assigned
Labels
website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @jamengual