-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add silence_pr_comments on plan and apply #4543
Merged
chenrui333
merged 4 commits into
runatlantis:main
from
anryko:feat_silence_pr_comments_1
Jun 1, 2024
Merged
feat: add silence_pr_comments on plan and apply #4543
chenrui333
merged 4 commits into
runatlantis:main
from
anryko:feat_silence_pr_comments_1
Jun 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anryko
requested review from
GenPage,
lukemassa and
X-Guardian
and removed request for
a team
May 13, 2024 17:30
github-actions
bot
added
docs
Documentation
go
Pull requests that update Go code
labels
May 13, 2024
1 task
chenrui333
previously approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@anryko can you pull the latest main and fix the conflicts? Thanks! |
anryko
force-pushed
the
feat_silence_pr_comments_1
branch
3 times, most recently
from
May 22, 2024 10:26
434728f
to
3c2e672
Compare
@chenrui333 I rebased and retested the feature locally. Some GH checks are failing, but it seems to be a build system issue... Thank you for the review! |
anryko
force-pushed
the
feat_silence_pr_comments_1
branch
from
May 22, 2024 15:23
3c2e672
to
1f15562
Compare
chenrui333
approved these changes
May 29, 2024
jamengual
approved these changes
May 31, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
Documentation
feature
New functionality/enhancement
go
Pull requests that update Go code
ready to merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
A feature to allow silencing
atlantis plan
andatlantis apply
on per repo/project basis. This is useful when running a big Atlantis server pool and/or having big repetitive changes. In those cases it could be preferable to rely on the GitHub status check and disable Atlantis comment responses.why
I have a distributed Atlantis setup where a single PR change is planned by many isolated instances. In this setup, each of those instances will post a repetitive comment response to the GitHub thread. It would be preferable to have an option to control this behavior.
With this feature, it would be possible to add a server-side
repo
or atlantis.yamlproject
level config option ofsilence_pr_comments: ["plan", "apply"]
and prevent Atlantis from posting the comment responses on those commands, while still reporting the status check updates.tests
references