fix: dont log GitHub app token in logs #4667
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobby-dobster
requested review from
jamengual,
nitrocode and
X-Guardian
and removed request for
a team
chenrui333
changed the title
nitrocode
approved these changes
Sep 6, 2024
jamengual
approved these changes
Sep 6, 2024
|
thanks @dobby-dobster for the contribution |
1 task
a1k0u
pushed a commit
to a1k0u/atlantis
that referenced
this pull request
Nov 1, 2024
Co-authored-by: Tom Baker <[email protected]> Signed-off-by: a1k0u <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Change the log line to prevent logging the GitHub App token in logs.
why
tests
Confirmed Atlantis continues to successfully start.
references