Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix: Preventing merging without running atlantis apply on Gitlab" #4721

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

jamengual
Copy link
Contributor

Reverts #4651

After checking this in more detail, we decided to revert this change.
This changes the user interface with the status in Gitlab.

in autoplan the status hang forever.

@jamengual jamengual requested review from a team as code owners July 3, 2024 17:32
@jamengual jamengual requested review from GenPage, lukemassa and X-Guardian and removed request for a team July 3, 2024 17:32
@github-actions github-actions bot added go Pull requests that update Go code size/xs labels Jul 3, 2024
@jamengual jamengual changed the title Revert "fix: Preventing merging without running atlantis apply on Gitlab" revert: "fix: Preventing merging without running atlantis apply on Gitlab" Jul 3, 2024
@jamengual jamengual merged commit b3d45d6 into main Jul 3, 2024
28 of 29 checks passed
@jamengual jamengual deleted the revert-4651-issues_4372 branch July 3, 2024 18:04
@amontalban
Copy link

@chenrui333 @jamengual when can we expect v0.28.4 container image to be released? Thanks!

ERROR: failed to solve: ghcr.io/runatlantis/atlantis:v0.28.4: ghcr.io/runatlantis/atlantis:v0.28.4: not found

@jamengual
Copy link
Contributor Author

mmmm that should have happened automatically, let me check

@jamengual
Copy link
Contributor Author

new release comming with the fix

@ebeltramo96
Copy link

Hello, any chance this can become an option via ENV variable etc? We would really love to have it active for our internal workflow

@m3adow
Copy link

m3adow commented Aug 20, 2024

After checking this in more detail, we decided to revert this change.

@jamengual, could you elaborate why? This was a great way to prevent a dirty main state in our repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants