Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added a space line #4787

Merged

Conversation

dorian-tsorfy
Copy link
Contributor

what

I added a space line to the policy_check_results_wrapped.tmpl file so the output on GitLab will look nice.
Resolving issue #4623.

why

We have noticed intermittent issues rendering the markdown Atlantis outputs to GitLab when a policy check failure occurs ever since upgrading from v0.27.3 to v0.28.1. I suspect this could be related to #4254 and the formatting changes it made.

tests

references

#4623

@dorian-tsorfy dorian-tsorfy requested review from a team as code owners July 25, 2024 14:25
@dorian-tsorfy dorian-tsorfy requested review from jamengual, lukemassa and X-Guardian and removed request for a team July 25, 2024 14:25
@dorian-tsorfy dorian-tsorfy changed the title added a space line fix: added a space line Jul 25, 2024
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamengual jamengual merged commit dac9141 into runatlantis:main Jul 25, 2024
26 checks passed
@chenrui333 chenrui333 added the bug Something isn't working label Jul 25, 2024
@X-Guardian
Copy link
Contributor

X-Guardian commented Aug 2, 2024

This PR is causing tests to fail in the main branch. Example: https://github.com/runatlantis/atlantis/actions/runs/10209313703/job/28247149152?pr=4804

--- FAIL: TestRenderProjectResults (0.01s)
    logger.go:146: 2024-08-02T03:08:09.809Z	INFO	log
    --- FAIL: TestRenderProjectResults/single_successful_policy_check_with_project_name (0.00s)
        --- FAIL: TestRenderProjectResults/single_successful_policy_check_with_project_name/single_successful_policy_check_with_project_name (0.00s)
            markdown_renderer_test.go:1192: [Ran Policy Check for project: `projectname` dir: `path` workspace: `workspace`

This file needs updating server/events/markdown_renderer_test.go.

@X-Guardian
Copy link
Contributor

@dorian-tsorfy, this PR has been reverted as it was causing the Test CI to fail. Can you raise another PR with this change plus the updates needed to the server/events/markdown_renderer_test.go file. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants