fix: update FileWorkspace logic to use pull request refs only when PR number is specified #4851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
pull/{pr.number}/head
if there is indeed a pull request number specified as part of the plan/apply.failed to build command: running git fetch origin pull/0/head:: fatal: couldn't find remote ref pull/0/head
main
for instance, this leads to 128 errors from git:why
/api/plan
throws 500 error when using GitHub App #4850/api/plan
and/api/apply
can optionally omit thePR
parameter. Therefore, we should check to see if it's0
before pivoting to a pull request based reference checkout.tests
references
https://github.com/runatlantis/atlantis/blob/6fe0303279839faadb76e94de94d7c250876b336/runatlantis.io/docs/api-endpoints.md#post-apiplan
Should close #4850