Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Atlantis replying to non-atlantis comments. #534

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Mar 13, 2019

Fixes #533, a regression where Atlantis will respond with errors to
comments that aren't intended to invoke Atlantis.

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #534 into master will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   72.18%   72.18%   -0.01%     
==========================================
  Files          62       62              
  Lines        4509     4516       +7     
==========================================
+ Hits         3255     3260       +5     
- Misses       1011     1012       +1     
- Partials      243      244       +1
Impacted Files Coverage Δ
server/server.go 67.65% <100%> (-0.12%) ⬇️
server/events/comment_parser.go 95.31% <69.23%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aab2211...11b97a4. Read the comment docs.

comments that aren't intended to invoke Atlantis.
Looks like we forgot to add the ability for bitbucket cloud/server users
to invoke Atlantis using the name of the user they're running it as.
@lkysow lkysow merged commit 2fb4913 into master Mar 13, 2019
@lkysow lkysow deleted the fix-comment-parsing branch March 13, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant