Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add policy checks to Azure DevOps #984

Merged
merged 14 commits into from
Apr 16, 2020
Merged

Add policy checks to Azure DevOps #984

merged 14 commits into from
Apr 16, 2020

Conversation

jpreese
Copy link
Contributor

@jpreese jpreese commented Apr 10, 2020

Adds policy checking to the Azure DevOps VCS client.

To assist with the reviews, I've left review comments on the code itself to help explain some of the additions.

Feedback welcomed and appreciated!

@cket cket mentioned this pull request Apr 10, 2020
Closed
@jpreese
Copy link
Contributor Author

jpreese commented Apr 13, 2020

Had some back and forth with @mcdafydd and we're good with this if you are, @lkysow

lkysow
lkysow requested changes Apr 13, 2020
View reviewed changes
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion with errors.wrap

server/events/vcs/azuredevops_client.go Outdated Show resolved Hide resolved
server/events/vcs/azuredevops_client.go Outdated Show resolved Hide resolved
@jpreese
Copy link
Contributor Author

jpreese commented Apr 13, 2020

@lkysow I updated the PR with the changes from the review, but it looks like the linting stage is exploding -- might be related to the recent linting changes?

@jpreese
Copy link
Contributor Author

jpreese commented Apr 15, 2020

and we're green!

lkysow
lkysow reviewed Apr 16, 2020
View reviewed changes
server/events/vcs/azuredevops_client.go
}

// Ignore the Atlantis status, even if its set as a blocker.
// This status should not be considered when evaluating if the pull request can be applied.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

lkysow
lkysow approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for fixing this and thanks for the review @mcdafydd.

@lkysow lkysow merged commit 3a44842 into runatlantis:master Apr 16, 2020
@jpreese jpreese mentioned this pull request Apr 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdafydd mcdafydd mcdafydd left review comments

@lkysow lkysow lkysow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpreese @lkysow @mcdafydd