-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide "plan" comments #994
Hide "plan" comments #994
Conversation
The golang Github client recommends this.
And implement the Github version. The Golang Github client recommends using shurcooL/githubv4.
So that every pull update will auto clean older comments
Co-Authored-By: Luke Kysow <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #994 +/- ##
==========================================
- Coverage 72.03% 71.95% -0.08%
==========================================
Files 65 65
Lines 5339 5406 +67
==========================================
+ Hits 3846 3890 +44
- Misses 1192 1210 +18
- Partials 301 306 +5
Continue to review full report at Codecov.
|
atlantis server --hide-prev-plan-comments | ||
``` | ||
Hide previous plan comments to declutter PRs. This is only supported in | ||
GitHub currently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lkysow I'm trying to figure out how to set a boolean flag like this via environment variable - before I go testing random settings (1, true, etc) maybe there could be some docs added to show how to do this?
Maybe a more generic bit in the "environment variable" section of the config docs would handle it for any boolean flags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can set it to the string false
or true
, e.g. ATLANTIS_HIDE_PREV_PLAN_COMMENTS=true
. Yeah I think adding this to https://www.runatlantis.io/docs/server-configuration.html#environment-variables would be great. PRs welcome please!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See discussion in runatlantis#994 (comment)
Updates #897 with master so it can be merged.