Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "plan" comments #994

Merged
merged 14 commits into from
Apr 16, 2020
Merged

Hide "plan" comments #994

merged 14 commits into from
Apr 16, 2020

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Apr 16, 2020

Updates #897 with master so it can be merged.

Fixes #721

Read commit by commit. Attempted to isolate changes.
Did not implement this for other VCS's. Github is my primary concern right now.
This will only hide "plan" comments, because IMO "apply" comments are important enough to >have unminimized because they impact actual systems and thus may be useful when people >need to audit changes or figure out what/how things broke.

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #994 into master will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
- Coverage   72.03%   71.95%   -0.08%     
==========================================
  Files          65       65              
  Lines        5339     5406      +67     
==========================================
+ Hits         3846     3890      +44     
- Misses       1192     1210      +18     
- Partials      301      306       +5     
Impacted Files Coverage Δ
cmd/server.go 79.72% <ø> (ø)
server/events/command_runner.go 49.37% <0.00%> (-0.63%) ⬇️
server/events/vcs/azuredevops_client.go 66.50% <0.00%> (-0.67%) ⬇️
server/events/vcs/bitbucketcloud/client.go 46.61% <0.00%> (-0.72%) ⬇️
server/events/vcs/bitbucketserver/client.go 34.88% <0.00%> (-0.42%) ⬇️
server/events/vcs/gitlab_client.go 38.65% <0.00%> (-0.67%) ⬇️
server/events/vcs/not_configured_vcs_client.go 0.00% <0.00%> (ø)
server/events/vcs/proxy.go 0.00% <0.00%> (ø)
server/user_config.go 100.00% <ø> (ø)
server/events/vcs/github_client.go 80.47% <84.90%> (+1.65%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d89710...80347f4. Read the comment docs.

atlantis server --hide-prev-plan-comments
```
Hide previous plan comments to declutter PRs. This is only supported in
GitHub currently.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lkysow I'm trying to figure out how to set a boolean flag like this via environment variable - before I go testing random settings (1, true, etc) maybe there could be some docs added to show how to do this?

Maybe a more generic bit in the "environment variable" section of the config docs would handle it for any boolean flags?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can set it to the string false or true, e.g. ATLANTIS_HIDE_PREV_PLAN_COMMENTS=true. Yeah I think adding this to https://www.runatlantis.io/docs/server-configuration.html#environment-variables would be great. PRs welcome please!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lkysow opened a PR for the docs: #1017

mwarkentin added a commit to mwarkentin/atlantis that referenced this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Clean up old comments
2 participants