Add /* as a default ingress path

[nitrocode]

what

• Add /* as a default ingress path

why

• This will allow access to / and other common atlantis api paths

references

• closes ingress doesn't forward any path except / #166

[lkysow]

Why can't you just make this change in your own values file?

[kvanzuijlen]

@lkysow This change didn't work for me with the default configuration in combination with an Nginx Ingress Controller. I had to revert the path to / to get it to work. Also, ImplementationSpecific and Prefix are the same thing for the Nginx Ingress controller (not sure about other LB implementations). Imo this change should therefore be unmerged and maybe handled in documentation instead, since this now inadvertently became a breaking change without a major version increase.

Further explanation:
Setting the path to /* will result in location /*/ { in the generated Nginx configuration, therefore not matching anything at all.

[nitrocode]

@lkysow I suppose someone could just override the values.

Apologies @kvanzuijlen for breaking your implementation.

The default would work well for AWS load balancer controller but not for nginx. Perhaps the middle ground is to document both deployments?