Allow configuring of basic authentication #98
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the runatlantis/atlantis v0.17.5 release, users are allowed to configure a basic authentication. The helm chart does not allow the
livenessProbe
andreadinessProbe
to add custom headers, so this PR adds support for both the creation of credentials and probes.In this PR you will find:
ATLANTIS_WEB_BASIC_AUTH
,ATLANTIS_WEB_USERNAME
,ATLANTIS_WEB_PASSWORD
)livenessProbe
andreadinessProbe
to add a basic authorization headerTested it manually, deploying atlantis in an EKS cluster.
Edit:
There's no need for
livenessProbe
andreadinessProbe
to add a basic authorization header since the bug was fixed in atlantis source code #1896, so the code was removed.