-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add static binaries to release #63
Merged
Shubhranshu153
merged 6 commits into
runfinch:main
from
coderbirju:make-binaries-static
Oct 30, 2024
Merged
fix: Add static binaries to release #63
Shubhranshu153
merged 6 commits into
runfinch:main
from
coderbirju:make-binaries-static
Oct 30, 2024
+42
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderbirju
force-pushed
the
make-binaries-static
branch
2 times, most recently
from
September 21, 2024 19:07
6057cc4
to
16c9c5c
Compare
coderbirju
changed the title
fix: Add static binaries to release
fix: Add static binaries to release [WIP]
Sep 23, 2024
cezar-r
previously approved these changes
Sep 23, 2024
coderbirju
force-pushed
the
make-binaries-static
branch
6 times, most recently
from
October 2, 2024 22:27
dbf3fb8
to
fcdb9d0
Compare
coderbirju
force-pushed
the
make-binaries-static
branch
from
October 2, 2024 22:28
fcdb9d0
to
a97a89a
Compare
coderbirju
force-pushed
the
make-binaries-static
branch
from
October 2, 2024 22:48
1f0c2e5
to
06276fa
Compare
coderbirju
changed the title
fix: Add static binaries to release [WIP]
fix: Add static binaries to release
Oct 2, 2024
henry118
reviewed
Oct 3, 2024
coderbirju
force-pushed
the
make-binaries-static
branch
from
October 13, 2024 04:04
06276fa
to
5887d3b
Compare
coderbirju
force-pushed
the
make-binaries-static
branch
5 times, most recently
from
October 24, 2024 18:42
852ca42
to
e698209
Compare
henry118
previously approved these changes
Oct 25, 2024
pendo324
reviewed
Oct 30, 2024
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
make-binaries-static
branch
from
October 30, 2024 21:01
6e95440
to
723e435
Compare
Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
make-binaries-static
branch
from
October 30, 2024 21:02
723e435
to
233d424
Compare
pendo324
approved these changes
Oct 30, 2024
Shubhranshu153
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
$ ldd ./finch-daemon linux-vdso.so.1 (0x00007ffc112ba000) libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x0000778e82c00000) /lib64/ld-linux-x86-64.so.2 (0x0000778e82e43000)
$ file ./finc-daemon
./finch-daemon: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=3db17231b58a26bfc842a2f4101034c909cee7e8, for GNU/Linux 3.2.0, with debug_info, not stripped
$ ldd ./finch-daemon not a dynamic executable
$ file ./finc-daemon
./finch-daemon: ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), statically linked, BuildID[sha1]=24763e08999dd8508011f063060edc54e00b8448, for GNU/Linux 3.2.0, with debug_info, not stripped
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.