revert: "always force stop when using Virtualization.framework"

[pendo324]

This reverts commit c521f1f.

Issue #, if available: After #368 is merged, the change to always force stop the VM is no longer necessary, since the upstream issue mentioned in #350 has been fixed in the new version of Lima.

Description of changes: Undo the changes in #350

Testing done:

• local testing

• unit tests

• I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Refs: c521f1f

[pendo324]

Yeah, I don't think we should merge this yet.

Looks like the new Lima release didn’t fix our issue 100% of the time. I actually can’t repro it after the first vm init + vm stop (tried like 10 times). To clarify, the issue still seems to exist on vm init + vm stop, but not vm start + vm stop.

I’ll see if this happens with regular/non-Finch Lima and post on the Lima GitHub if there’s not already an issue

INFO[0000] Stopping existing Finch virtual machine...
ERRO[0180] Finch virtual machine failed to stop, debug logs:
time="2023-04-18T12:54:33-04:00" level=info msg="Sending SIGINT to hostagent process 89382"
time="2023-04-18T12:54:33-04:00" level=info msg="Waiting for the host agent and the driver processes to shut down"
time="2023-04-18T12:54:33-04:00" level=info msg="[hostagent] 2023/04/18 12:52:50 tcpproxy: for incoming conn 127.0.0.1:56378, error dialing \"192.168.5.15:22\": connect tcp 192.168.5.15:22: no route to host"
time="2023-04-18T12:54:33-04:00" level=info msg="[hostagent] 2023/04/18 12:53:00 tcpproxy: for incoming conn 127.0.0.1:56401, error dialing \"192.168.5.15:22\": connect tcp 192.168.5.15:22: connection was refused"
time="2023-04-18T12:54:33-04:00" level=info msg="[hostagent] 2023/04/18 12:53:10 tcpproxy: for incoming conn 127.0.0.1:56427, error dialing \"192.168.5.15:22\": connect tcp 192.168.5.15:22: connection was refused"
time="2023-04-18T12:54:33-04:00" level=info msg="[hostagent] Received SIGINT, shutting down the host agent"
time="2023-04-18T12:54:33-04:00" level=info msg="[hostagent] Shutting down the host agent"
time="2023-04-18T12:54:33-04:00" level=info msg="[hostagent] Stopping forwarding \"/run/lima-guestagent.sock\" (guest) to \"/Users/alvajus/Code/finch/_output/lima/data/finch/ga.sock\" (host)"
time="2023-04-18T12:54:33-04:00" level=info msg="[hostagent] Unmounting disk \"finch\""
time="2023-04-18T12:54:33-04:00" level=info msg="[hostagent] Shutting down VZ"
time="2023-04-18T12:54:35-04:00" level=info msg="[hostagent] panic: runtime/cgo: misuse of an invalid Handle"
time="2023-04-18T12:54:35-04:00" level=info msg="[hostagent] goroutine 17 [running, locked to thread]:"
time="2023-04-18T12:54:35-04:00" level=info msg="[hostagent] runtime/cgo.Handle.Value(...)"
time="2023-04-18T12:54:35-04:00" level=info msg="[hostagent] \t/usr/local/Cellar/go/1.20.3/libexec/src/runtime/cgo/handle.go:124"
time="2023-04-18T12:54:35-04:00" level=info msg="[hostagent] github.com/Code-Hex/vz/v3.changeStateOnObserver("
time="2023-04-18T12:54:35-04:00" level=info msg="[hostagent] 0xc000006601?"
time="2023-04-18T12:54:35-04:00" level=info msg="[hostagent] )"
time="2023-04-18T12:54:35-04:00" level=info msg="[hostagent] \t/Users/ec2-user/go/pkg/mod/github.com/!code-!hex/vz/[email protected]/virtualization.go:160 +0xb4"
time="2023-04-18T12:57:33-04:00" level=fatal msg="did not receive an event with the \"exiting\" status"
FATA[0180] exit status 1

[pendo324]

Overriding and merging due to a few Windows test flakes