Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add finch vm settings subcommand #887

Merged
merged 9 commits into from
Apr 19, 2024
Merged

fix: add finch vm settings subcommand #887

merged 9 commits into from
Apr 19, 2024

Commits on Apr 15, 2024

  1. fix: add finch vm settings subcommand 

    The current implementation requires updating ~/.finch/finch.yaml to change
the CPU and Memory settings in the VM.

However, the following issue provides a feature request to set the CPU and
memory resources to be allocated to the VM from CLI options.

- runfinch#683

Therefore, this fix adds the finch vm settings command to add the ability
to set the CPU and memory resources allocated to VMs from the CLI.

Signed-off-by: Hayato Kiwata <[email protected]>
    @haytok
    haytok committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    1fc8df9 View commit details
    Browse the repository at this point in the history

  2. fix: add finch vm settings subcommand 

    Based on the review, the code has been modified.

Signed-off-by: Hayato Kiwata <[email protected]>
    @haytok
    haytok committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    2331c70 View commit details
    Browse the repository at this point in the history

  3. fix: add finch vm settings subcommand 

    Signed-off-by: Hayato Kiwata <[email protected]>
    @haytok
    haytok committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    dc941d8 View commit details
    Browse the repository at this point in the history

  4. fix: add finch vm settings subcommand 

    fix to pass CI

Signed-off-by: Hayato Kiwata <[email protected]>
    @haytok
    haytok committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    687046d View commit details
    Browse the repository at this point in the history

  5. fix: add finch vm settings subcommand 

    fix to pass CI

Signed-off-by: Hayato Kiwata <[email protected]>
    @haytok
    haytok committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    42558fb View commit details
    Browse the repository at this point in the history

  6. fix: add finch vm settings subcommand 

    Refactoring so that make test-unit passes.
Also, modified and added tests.

Signed-off-by: Hayato Kiwata <[email protected]>
    @haytok
    haytok committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    459935e View commit details
    Browse the repository at this point in the history

  7. fix: add finch vm settings subcommand 

    Changed the CPUs value of the test to a value smaller than the CPUs
allocated to GitHub Actions.

Signed-off-by: Hayato Kiwata <[email protected]>
    @haytok
    haytok committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    9f31ced View commit details
    Browse the repository at this point in the history

  8. fix: add finch vm settings subcommand 

    We implemented the tests by separating the test cases for macOS and
Windows.

Signed-off-by: Hayato Kiwata <[email protected]>
    @haytok
    haytok committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    18fabc9 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. fix: add finch vm settings subcommand 

    fix to pass CI

Signed-off-by: Hayato Kiwata <[email protected]>
    @haytok
    haytok committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ed3a3c1 View commit details
    Browse the repository at this point in the history