build(windows): add yq and bump versions #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <[email protected]>
1 task
Shubhranshu153
approved these changes
Apr 29, 2024
Signed-off-by: Justin Alvarez <[email protected]>
pendo324
added a commit
to runfinch/finch
that referenced
this pull request
Apr 29, 2024
Issue #, if available: *Description of changes:* To avoid issues where properties that are supposed to be the same (e.g. the nerdctl-full archive) end up mismatched, I've introduced a way to build our YAML files from a common source using [yq ](https://github.com/mikefarah/yq) This won't work on Windows until this is merged to install yq on the Windows runners runfinch/infrastructure#594 *Testing done:* - Local testing - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Justin Alvarez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The large diff is because I also applied formatting. Ignoring whitespace when reviewing should help
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.