This repository has been archived by the owner on Jul 3, 2020. It is now read-only.
Mouse support #131
Open
Mouse support #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, this is nice! Looks pretty simple, assumed mouse would be complicated 😄 I hope to wrap up tests pretty soon and make them working again, then going to hack on modules (hope this weekend). Modules will let us add any (experimental) features easily. Not sure if realistic or too crazy, but if we manage to support webgl (through virtio-gpu) we might be able to run some WASM-compiled games on it :) |
| @@ -41,6 +41,7 @@ rules: | |||
| - 2 | |||
| - | |||
| props: false | |||
| no-shadow: 0 | |||
There was a problem hiding this comment.
I guess a good rule, why disable?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, I had some free time and nothing to do, so... mouse driver! 😄 Thought this would go nicely with graphics. Has a few kinks, though. For example, you have to wait until after the driver is installed (usually about 2/3 seconds after the shell is displayed) in order to be able to click into QEMU (otherwise the system, or at least the keyboard, will freeze up). Also, no hot plugging (you can't escape the mouse to the host and go back). Otherwise, it's pretty decent mouse driver implementation.
Again, as mentioned in #107 (specifically this comment), this should be refactored into an optional module with other things.