-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper changes for symbolic testing #769
Conversation
@ehildenb Except one question above this is ready for review. Should pass the tests. |
It looks pretty good to me, but can @daejunpark look and @virgil-serbanuta as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable, I have one small question.
@ehildenb @daejunpark All comments addressed. I see it passes now. No idea why it was failing before. Changes are unrelated to failure. Ready for re-review. |
c4535d2
to
544c2ca
Compare
005e91a
to
24d411e
Compare
Please don't merge the update submodule PR into this one @denis-bogdanas . Instead, you can just approve that PR and get it merged directly, then merge master into this one. If other PRs update the submodules, then the submodule updater gets confused, it can't handle merge conflicts at all. |
This PR would pass tests with latest K, but K update PR fails for other reasons as you can see. That one must be fixed first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think that it would be better to ask the backend to resolve that ceil
, but I guess that this is also fine.
@ehildenb We need updated K for this PR to pass. Other than that it looks ready. |
We're waiting on a regression in the LLVM backend to update K. I'll keep you posted, thanks! |
2efcf56
to
c298ce4
Compare
…th) & related rules"
@ehildenb ready for review |
… Haskell backend."
No description provided.