-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve timestamp updates #783
Conversation
I'm somewhat skeptical of all the places we've added updates to the It may only actually be needed at the beginning of execution (by putting |
Let's add just an |
fixes: https://github.com/runtimeverification/firefly/issues/822
This PR introduces a
<lastMineTime>
cell, which helps to track the passage of time from the last mining of a block. This is necessary because<timestamp>
can be manipulated in ways such as custom initialization,evm_revert
andevm_increaseTime
, which makes just updating the cell with#time()
incorrect.